diff options
| author | garret1317 <garret@airmail.cc> | 2025-11-20 12:10:23 +0000 |
|---|---|---|
| committer | garret1317 <garret@airmail.cc> | 2025-11-20 12:16:42 +0000 |
| commit | 36641cc5ecb7dd00e2300715dee00ac4fe653953 (patch) | |
| tree | f537d19bb6258976dbe3096a470196f38ab23e21 /yt_dlp_plugins/extractor/radiko_podcast.py | |
| parent | 35f0dabb6600848599ca9558899c05a514e7a5cf (diff) | |
| download | yt-dlp-rajiko-36641cc5ecb7dd00e2300715dee00ac4fe653953.tar.gz yt-dlp-rajiko-36641cc5ecb7dd00e2300715dee00ac4fe653953.tar.bz2 yt-dlp-rajiko-36641cc5ecb7dd00e2300715dee00ac4fe653953.zip | |
Fix TOCTOU bug where only one stream was actually downloadable
because the playlist_url, domain, first_chunk etc gets re-set by the next items in the loop
and the fragments_generator() joyously goes ahead and uses those values, because that's what's there
and ^it's a generator so i didnt even need to have the separate fragments_generator func anyway
sigh....
well fortunately it failed such that it always downloaded wowza stream which is the best one
but still sigh...
no wonder both formats looked the same in the spectrum analyser lmao
i suppose this is TOCTOU https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use
i found this while trying to download 24 hours of silence lmao
https://radiko.jp/#!/ts/OC1/20251119050000
"OC1", prob means 'original content 1'
※配信期間外です LAWSON SEEDS OF CREATION 配信日:2025年11月23日(日)22:00~23:02
※配信期間外は無音となります。 LAWSON SEEDS OF CREATIONで放送されなかったJAM’S からメンバーへの質問を特別にオンエアー! あのヒット曲について語る!
wowza stream errors but smartstream is fine
so it correctly selected the smartstream stream
but the frags it tried to dl were from the wowza stream
fun
Diffstat (limited to 'yt_dlp_plugins/extractor/radiko_podcast.py')
0 files changed, 0 insertions, 0 deletions